linux-kernel - Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=V=pRSP4FkJciYkpHa=A8i_GjGTz64Kzz_h9eGFQeD1cA@mail.gmail.com>
Date:   Mon, 15 Mar 2021 10:40:30 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Alexandru M Stan <amstan@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rob Clark <robdclark@...omium.org>,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>,
        Tanmay Shah <tanmay@...eaurora.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy
 inside QMP phy

Hi,

On Sat, Mar 13, 2021 at 4:28 PM Dmitry Baryshkov
<dmitry.baryshkov@...aro.org> wrote:
>
> >               usb_1_qmpphy: phy-wrapper@...9000 {
> > -                     compatible = "qcom,sc7180-qmp-usb3-phy";
> > +                     compatible = "qcom,sc7180-qmp-usb3-dp-phy";
> >                       reg = <0 0x088e9000 0 0x18c>,
> > -                           <0 0x088e8000 0 0x38>;
> > -                     reg-names = "reg-base", "dp_com";
> > +                           <0 0x088e8000 0 0x38>,
>
> Technically this should be 0x3c. Offset 0x38 is USB3_DP_COM_REVISION_ID3
> (not used by the current driver though).
>
> > +                           <0 0x088ea000 0 0x40>;
>
> I think 0x40 is not enough here.
> This is a serdes region and qmp_v3_dp_serdes_tbl contains registers
> 0x148 and 0x154.

OK!

https://lore.kernel.org/r/20210315103836.1.I9a97120319d43b42353aeac4d348624d60687df7@changeid

-Doug