linux-kernel - [PATCH] usb: dwc3: remove 'pm_runtime_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Mar 2021 16:43:17 +0900
From:   taehyun cho <taehyun.cho@...sung.com>
To:     balbi@...nel.org
Cc:     taehyun.cho@...sung.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] usb: dwc3: remove 'pm_runtime_set_active' in resume
 callback

'pm_runtime_set_active' sets a flag to describe rumtime status.
This flag is automatically set in pm_runtime_get_sync/put_sync API.
'pm_runtime_set_active' checks the runtime status of parent device.
As a result, the below error message is printed.
dwc3 11110000.dwc3: runtime PM trying to activate child device
11110000.dwc3 but parent (11110000.usb) is not active.

Signed-off-by: taehyun cho <taehyun.cho@...sung.com>
---
 drivers/usb/dwc3/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 94fdbe502ce9..e7c0e390f885 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1553,7 +1553,6 @@ static int dwc3_probe(struct platform_device *pdev)
 
 	spin_lock_init(&dwc->lock);
 
-	pm_runtime_set_active(dev);
 	pm_runtime_use_autosuspend(dev);
 	pm_runtime_set_autosuspend_delay(dev, DWC3_DEFAULT_AUTOSUSPEND_DELAY);
 	pm_runtime_enable(dev);
@@ -1920,7 +1919,6 @@ static int dwc3_resume(struct device *dev)
 		return ret;
 
 	pm_runtime_disable(dev);
-	pm_runtime_set_active(dev);
 	pm_runtime_enable(dev);
 
 	return 0;
-- 
2.26.0