linux-kernel - Re: [PATCH net] wireless/nl80211: fix wdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfmpSfJ-t6pPC+Bwu0UrWH9w9edgcM-Y+qKAXBNx0NSXw_ZEQ@mail.gmail.com>
Date:   Mon, 15 Mar 2021 14:20:49 -0400
From:   Jarod Wilson <jarod@...hat.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo <kvalo@...eaurora.org> wrote:
>
> Jarod Wilson <jarod@...hat.com> writes:
>
> > Build currently fails with -Werror=maybe-uninitialized set:
> >
> > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs':
> > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
>
> Really, build fails? Is -Werror enabled by default now? I hope not.

Don't think so. But we (Red Hat) build all our kernels with a fair
amount of extra error-checking enabled.

-- 
Jarod Wilson
jarod@...hat.com