linux-kernel - Re: [PATCH v4 7/7] dt-bindings: clock: tegra: Convert to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aae4fb3-6b45-24ea-df2d-63746ec2afda@gmail.com>
Date:   Mon, 15 Mar 2021 22:07:11 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-tegra@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 7/7] dt-bindings: clock: tegra: Convert to schema

15.03.2021 18:53, Rob Herring пишет:
> On Fri, Mar 12, 2021 at 07:36:32PM +0300, Dmitry Osipenko wrote:
>> Convert NVIDIA Tegra clock bindings to schema.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  .../bindings/clock/nvidia,tegra-car.yaml      | 118 ++++++++++++++++++
>>  .../bindings/clock/nvidia,tegra114-car.txt    |  63 ----------
>>  .../bindings/clock/nvidia,tegra124-car.txt    | 107 ----------------
> 
> Seems like this one is a bit different and should remain a separate 
> binding?

The T124 binding has optional EMC (external memory controller) clocks
that aren't used by other SoCs. The T124 also shouldn't need these
clocks, but that's how the binding happened to be defined historically.
Since the optional properties have no effect on a non-T124 SoCs, I
thought that it should be better to unify all the bindings, rather than
partially duplicate them with out any real benefit.