linux-kernel - Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wg0DY=cE-6Tjp_Dt32UC6XtMZBa0Rr2GqkK=Sh9HE=5kQ@mail.gmail.com>
Date:   Mon, 15 Mar 2021 12:12:41 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Rong Chen <rong.a.chen@...el.com>
Cc:     kernel test robot <lkp@...el.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch

On Sun, Mar 14, 2021 at 7:32 PM Rong Chen <rong.a.chen@...el.com> wrote:
>
> It can be reproduced with '-a' option in dash:

Oh, ok. That kind of explains it.

'dash' is trash. Please somebody make a bug report.

>      $ a="!"
>      $ [ "$a" = ".size" ]
>      $ [ "$a" = ".size" -a "$b" = ".LPBX0," ]
>      sh: 2: [: =: unexpected operator

This is 100% a dash bug. There is no question what-so-ever about it.
This is not some kind of "POSIX is ambiguous", or "the handling of
'-a' is complicated".

It's simply just that dash is buggy.

>  While dash supports most uses of the -a and -o options, they have
> very confusing semantics even in bash and are best avoided.

No, they have perfectly sane semantics in bash, and in POSIX.

See

     https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

and there is absolutely zero question that bash does this correctly,
and dash does not.

But yes, it seems to be easy to work around, but still - could some
Ubuntu person please open a bug report on dash?

               Linus