linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqsYR+uCmBH8i6H_YyBfcmziiCq9dAZkAqJUEEvHZ3AUg@mail.gmail.com>
Date:   Mon, 15 Mar 2021 22:19:35 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>,
        Tanmay Shah <tanmay@...eaurora.org>,
        Rob Clark <robdclark@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes

On Mon, 15 Mar 2021 at 20:39, Douglas Anderson <dianders@...omium.org> wrote:
>
> As per Dmitry Baryshkov [1]:
> a) The 2nd "reg" should be 0x3c because "Offset 0x38 is
>    USB3_DP_COM_REVISION_ID3 (not used by the current driver though)."
> b) The 3rd "reg" "is a serdes region and qmp_v3_dp_serdes_tbl contains
>    registers 0x148 and 0x154."
>
> I think because the 3rd "reg" is a serdes region we should just use
> the same size as the 1st "reg"?

Yes, this looks logical to me.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

>
> [1] https://lore.kernel.org/r/ee5695bb-a603-0dd5-7a7f-695e919b1af1@linaro.org
>
> Cc: Stephen Boyd <swboyd@...omium.org>
> Cc: Jeykumar Sankaran <jsanka@...eaurora.org>
> Cc: Chandan Uddaraju <chandanu@...eaurora.org>
> Cc: Vara Reddy <varar@...eaurora.org>
> Cc: Tanmay Shah <tanmay@...eaurora.org>
> Cc: Rob Clark <robdclark@...omium.org>
> Fixes: 58fd7ae621e7 ("arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy")
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 83fbb481cae5..61732e5efe62 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2754,8 +2754,8 @@ usb_1_hsphy: phy@...3000 {
>                 usb_1_qmpphy: phy-wrapper@...9000 {
>                         compatible = "qcom,sc7180-qmp-usb3-dp-phy";
>                         reg = <0 0x088e9000 0 0x18c>,
> -                             <0 0x088e8000 0 0x38>,
> -                             <0 0x088ea000 0 0x40>;
> +                             <0 0x088e8000 0 0x3c>,
> +                             <0 0x088ea000 0 0x18c>;
>                         status = "disabled";
>                         #address-cells = <2>;
>                         #size-cells = <2>;

-- 
With best wishes
Dmitry