linux-kernel - Re: [PATCHv3 2/6] arm64: don't use GENERIC_IRQ_MULTI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210315192803.GB154861@infradead.org>
Date:   Mon, 15 Mar 2021 19:28:03 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        will@...nel.org, catalin.marinas@....com, james.morse@....com,
        marcan@...can.st, maz@...nel.org, tglx@...utronix.de
Subject: Re: [PATCHv3 2/6] arm64: don't use GENERIC_IRQ_MULTI_HANDLER

On Mon, Mar 15, 2021 at 11:56:25AM +0000, Mark Rutland wrote:
> From: Marc Zyngier <maz@...nel.org>
> 
> In subsequent patches we want to allow irqchip drivers to register as
> FIQ handlers, with a set_handle_fiq() function. To keep the IRQ/FIQ
> paths similar, we want arm64 to provide both set_handle_irq() and
> set_handle_fiq(), rather than using GENERIC_IRQ_MULTI_HANDLER for the
> former.

Having looked through the series I do not understand this rationale
at all.  You've only added the default_handle_irq logic, which seems
perfectly suitable and desirable for the generic version.  Please
don't fork off generic code for no good reason.