linux-kernel - Re: [PATCH] scsi: qla2xxx: use dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A7ADAED-6A7C-4855-A6AB-6786896BDE03@oracle.com>
Date:   Mon, 15 Mar 2021 19:46:18 +0000
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Wang Qing <wangqing@...o.com>
CC:     Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Martin Petersen <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead



> On Mar 12, 2021, at 8:41 PM, Wang Qing <wangqing@...o.com> wrote:
> 
> use dma_pool_zalloc instead of dma_pool_alloc and memset
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 0743925..ac5e954
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4238,11 +4238,10 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
> 
> 	/* Get consistent memory allocated for Special Features-CB. */
> 	if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
> -		ha->sf_init_cb = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL,
> +		ha->sf_init_cb = dma_pool_zalloc(ha->s_dma_pool, GFP_KERNEL,
> 						&ha->sf_init_cb_dma);
> 		if (!ha->sf_init_cb)
> 			goto fail_sf_init_cb;
> -		memset(ha->sf_init_cb, 0, sizeof(struct init_sf_cb));
> 		ql_dbg_pci(ql_dbg_init, ha->pdev, 0x0199,
> 			   "sf_init_cb=%p.\n", ha->sf_init_cb);
> 	}
> -- 
> 2.7.4
> 

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

--
Himanshu Madhani	 Oracle Linux Engineering