[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BL0PR04MB6514FC8F5D34120DFFF727BCE76C9@BL0PR04MB6514.namprd04.prod.outlook.com>
Date: Mon, 15 Mar 2021 20:17:43 +0000
From: Damien Le Moal <Damien.LeMoal@....com>
To: Matthew Wilcox <willy@...radead.org>,
Matteo Croce <mcroce@...ux.microsoft.com>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Lennart Poettering <lennart@...ttering.net>,
Luca Boccassi <bluca@...ian.org>, Jens Axboe <axboe@...nel.dk>,
Alexander Viro <viro@...iv.linux.org.uk>,
Tejun Heo <tj@...nel.org>,
Javier González <javier@...igon.com>,
Niklas Cassel <Niklas.Cassel@....com>,
Johannes Thumshirn <Johannes.Thumshirn@....com>,
Hannes Reinecke <hare@...e.de>,
Ajay Joshi <Ajay.Joshi@....com>,
Christoph Hellwig <hch@....de>,
Matias Bjorling <Matias.Bjorling@....com>,
Hans Holmberg <Hans.Holmberg@....com>,
Dmitry Fomichev <Dmitry.Fomichev@....com>,
Keith Busch <kbusch@...nel.org>,
"Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH -next 2/5] block: add ioctl to read the disk sequence
number
On 2021/03/16 5:14, Matthew Wilcox wrote:
> On Mon, Mar 15, 2021 at 09:02:39PM +0100, Matteo Croce wrote:
>> +++ b/include/uapi/linux/fs.h
>> @@ -184,6 +184,7 @@ struct fsxattr {
>> #define BLKSECDISCARD _IO(0x12,125)
>> #define BLKROTATIONAL _IO(0x12,126)
>> #define BLKZEROOUT _IO(0x12,127)
>> +#define BLKGETDISKSEQ _IOR(0x12,128,__u64)
>> /*
>> * A jump here: 130-131 are reserved for zoned block devices
>> * (see uapi/linux/blkzoned.h)
>
> Not your bug, but this is now 130-136.
>
> +cc all the people who signed off on the commits that added those ioctl
> numbers without updating this comment. Perhaps one of them will figure
> out how to stop this happening in future.
>
Indeed. Will be more careful :)
And send a patch to fix this.
Thanks !
--
Damien Le Moal
Western Digital Research
Powered by blists - more mailing lists