linux-kernel - Re: [PATCH] Documentation: sysrq: update description about sysrq crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zgz4yxmc.fsf@meer.lwn.net>
Date:   Mon, 15 Mar 2021 14:23:39 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Gao Xiang <hsiangkao@...hat.com>, linux-doc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Gao Xiang <hsiangkao@...hat.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Zefan Li <lizefan.x@...edance.com>
Subject: Re: [PATCH] Documentation: sysrq: update description about sysrq crash

Gao Xiang <hsiangkao@...hat.com> writes:

> After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
> a crash was not generated by dereferencing a NULL pointer anymore.
>
> Let's update documentation as well to make it less misleading.
>
> Cc: Matthias Kaehlcke <mka@...omium.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Zefan Li <lizefan.x@...edance.com>
> Signed-off-by: Gao Xiang <hsiangkao@...hat.com>
> ---
>  Documentation/admin-guide/sysrq.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 67dfa4c29093..60ce5f5ebab6 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -90,8 +90,8 @@ Command	    Function
>  ``b``	    Will immediately reboot the system without syncing or unmounting
>              your disks.
>  
> -``c``	    Will perform a system crash by a NULL pointer dereference.
> -            A crashdump will be taken if configured.
> +``c``	    Will perform a system crash and a crashdump will be taken
> +            if configured.

Makes sense. Applied, thanks.

jon