linux-kernel - Re: [PATCH] signal: remove duplicate include in signal.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202103151346.F7FE09F43D@keescook>
Date:   Mon, 15 Mar 2021 13:47:02 -0700
From:   Kees Cook <keescook@...omium.org>
To:     menglong8.dong@...il.com
Cc:     ebiederm@...ssion.com, gustavoars@...nel.org,
        viro@...iv.linux.org.uk, zhang.yunkai@....com.cn, pcc@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signal: remove duplicate include in signal.h

On Sat, Mar 13, 2021 at 03:11:08AM -0800, menglong8.dong@...il.com wrote:
> From: Zhang Yunkai <zhang.yunkai@....com.cn>
> 
> 'linux/string.h' included in 'signal.h' is duplicated.
> It is also included in the 7th line.
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@....com.cn>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  include/linux/signal.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/signal.h b/include/linux/signal.h
> index 205526c4003a..c371d3a3ff61 100644
> --- a/include/linux/signal.h
> +++ b/include/linux/signal.h
> @@ -124,7 +124,6 @@ static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
>  #define sigmask(sig)	(1UL << ((sig) - 1))
>  
>  #ifndef __HAVE_ARCH_SIG_SETOPS
> -#include <linux/string.h>
>  
>  #define _SIG_SET_BINOP(name, op)					\
>  static inline void name(sigset_t *r, const sigset_t *a, const sigset_t *b) \
> -- 
> 2.25.1
> 

-- 
Kees Cook