linux-kernel - Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wj6OiV_sSZbqz-ZPnL7=NboN-3VQYM6brVCfq2px0EAqg@mail.gmail.com>
Date:   Mon, 15 Mar 2021 13:57:58 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Rong Chen <rong.a.chen@...el.com>,
        kernel test robot <lkp@...el.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch

On Mon, Mar 15, 2021 at 1:32 PM Jamie Heilman
<jamie@...ible.transient.net> wrote:
>
> fwiw, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850202

Yup, that seems to be the exact same thing from 4 years ago.

But it looks like nothing ever came out of it. It probably stayed
within the Debian bugzilla, and didn't go to upstream dash
maintainers.

It does look like dash is actually actively maintained, and it's even
a kernel maintainer that does it: Herbert Xu seems to maintain the
dash tree and I see commits from January.

So maybe we can get it fixed by just cc'ing Herbert.

Herbert, easy test-case:

    $ [ "!" = ".size" ]

works, but

    $ [ "!"  = ".size" -a "b" = ".LPBX0," ]

causes

    dash: 6: [: =: unexpected operator

because for some reason that "-a" ends up (wild handwaving here about
what is going on) re-parsing the first expression, and ignoring the
quoting around "!" when it does so.

I verified that the bug still exists in that current dash source tree,
but I didn't dig any deeper than that "wild handwaving guess" as to
what is actually going on.

                Linus