linux-kernel - Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YE/WVGaqJafUFbaC@piout.net>
Date:   Mon, 15 Mar 2021 22:49:08 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Chris Wilson <chris@...is-wilson.co.uk>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xiaofei Tan <tanxiaofei@...wei.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH] rtc: cmos: Disable irq around direct invocation of
 cmos_interrupt()

On 05/03/2021 15:27:52+0200, Ville Syrjälä wrote:
> > which breaks S3-resume on fi-kbl-soraka presumably as that's slow enough
> > to trigger the alarm during the suspend.
> > 
> > Fixes: 6950d046eb6e ("rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ")
> 
> Sigh. I wish people would at least try to check the code/history
> before doing these blind "cleanups" :(
>

Sorry I didn't catch that when applying. I'm usually more wary when
getting those kind of cleanups.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com