linux-kernel - Re: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Mar 2021 08:49:13 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Sergei Trofimovich <slyfox@...too.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq

On 13-03-21, 10:42, Sergei Trofimovich wrote:
> Fix warning with %lx / s64 mismatch:
> 
>   CC [M]  drivers/cpufreq/ia64-acpi-cpufreq.o
>     drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
>       warning: format '%lx' expects argument of type 'long unsigned int',
>       but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]
> 
> CC: "Rafael J. Wysocki" <rjw@...ysocki.net>
> CC: Viresh Kumar <viresh.kumar@...aro.org>
> CC: linux-pm@...r.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>
> ---
>  drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index 2efe7189ccc4..c6bdc455517f 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -54,7 +54,7 @@ processor_set_pstate (
>  	retval = ia64_pal_set_pstate((u64)value);
>  
>  	if (retval) {
> -		pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
> +		pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n",
>  		        value, retval);
>  		return -ENODEV;
>  	}
> @@ -77,7 +77,7 @@ processor_get_pstate (
>  
>  	if (retval)
>  		pr_debug("Failed to get current freq with "
> -			"error 0x%lx, idx 0x%x\n", retval, *value);
> +			"error 0x%llx, idx 0x%x\n", retval, *value);
>  
>  	return (int)retval;
>  }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh