linux-kernel - Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3d33f82-21ab-2244-13b0-700fc54b2093@oracle.com>
Date:   Tue, 16 Mar 2021 19:08:38 +0200
From:   Mihai Carabas <mihai.carabas@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        bobo.shaobowang@...wei.com, rdunlap@...radead.org
Subject: Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

..snip..
>> +};
>> +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
>> +static unsigned int events;
>> +
>> +static ssize_t capability_show(struct device *dev,
>> +			       struct device_attribute *attr, char *buf)
>> +{
>> +	return sysfs_emit(buf, "%x\n", capability);
> A global capability for all devices?  No, this needs to be a per-device
> attttribute as you are showing it to userspace as such.

We can only have a pvpanic-pci device. This is necessary in that case?

...snip..
>> +static struct attribute *pvpanic_pci_dev_attrs[] = {
>> +	&dev_attr_capability.attr,
>> +	&dev_attr_events.attr,
>> +	NULL
>> +};
>> +ATTRIBUTE_GROUPS(pvpanici_pci_dev);
> You did not document these new sysfs files in Documentation/ABI/ so it's
> hard to judge what they do.  Please do so next version.

This appeared after 5.12 rebase on pvpanic-mmio. I did this changes to 
pvpanic-pci to be on the same page as pvpanic-mmio which is described 
here: Documentation/ABI/testing/sysfs-bus-pci-devices-pvpanic.

Thank you,
Mihai