| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Mar 2021 01:18:23 +0800
From: kernel test robot <lkp@...el.com>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>
Cc: kbuild-all@...ts.01.org,
Linux Memory Management List <linux-mm@...ck.org>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>,
Huang Ying <ying.huang@...el.com>,
Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCH] mm: Move page_mapping_file to pagemap.h
Hi "Matthew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-linux-mm/master]
url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/mm-Move-page_mapping_file-to-pagemap-h/20210316-221138
base: https://github.com/hnaz/linux-mm master
config: mips-randconfig-r032-20210316 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5f7b112de945843f38fbf9f602dd547010e8b8d0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthew-Wilcox-Oracle/mm-Move-page_mapping_file-to-pagemap-h/20210316-221138
git checkout 5f7b112de945843f38fbf9f602dd547010e8b8d0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
arch/mips/mm/cache.c: In function '__flush_dcache_page':
>> arch/mips/mm/cache.c:85:34: error: implicit declaration of function 'page_mapping_file'; did you mean 'page_mapping'? [-Werror=implicit-function-declaration]
85 | struct address_space *mapping = page_mapping_file(page);
| ^~~~~~~~~~~~~~~~~
| page_mapping
>> arch/mips/mm/cache.c:85:34: warning: initialization of 'struct address_space *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
arch/mips/mm/cache.c: At top level:
arch/mips/mm/cache.c:129:6: warning: no previous prototype for '__update_cache' [-Wmissing-prototypes]
129 | void __update_cache(unsigned long address, pte_t pte)
| ^~~~~~~~~~~~~~
arch/mips/mm/cache.c:236:12: warning: no previous prototype for '__uncached_access' [-Wmissing-prototypes]
236 | int __weak __uncached_access(struct file *file, unsigned long addr)
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +85 arch/mips/mm/cache.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 82
^1da177e4c3f41 Linus Torvalds 2005-04-16 83 void __flush_dcache_page(struct page *page)
^1da177e4c3f41 Linus Torvalds 2005-04-16 84 {
cb9f753a3731f7 Huang Ying 2018-04-05 @85 struct address_space *mapping = page_mapping_file(page);
^1da177e4c3f41 Linus Torvalds 2005-04-16 86 unsigned long addr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 87
^1da177e4c3f41 Linus Torvalds 2005-04-16 88 if (mapping && !mapping_mapped(mapping)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 89 SetPageDcacheDirty(page);
^1da177e4c3f41 Linus Torvalds 2005-04-16 90 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 91 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 92
^1da177e4c3f41 Linus Torvalds 2005-04-16 93 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 94 * We could delay the flush for the !page_mapping case too. But that
^1da177e4c3f41 Linus Torvalds 2005-04-16 95 * case is for exec env/arg pages and those are %99 certainly going to
^1da177e4c3f41 Linus Torvalds 2005-04-16 96 * get faulted into the tlb (and thus flushed) anyways.
^1da177e4c3f41 Linus Torvalds 2005-04-16 97 */
234859e49a1532 Paul Burton 2016-03-01 98 if (PageHighMem(page))
234859e49a1532 Paul Burton 2016-03-01 99 addr = (unsigned long)kmap_atomic(page);
234859e49a1532 Paul Burton 2016-03-01 100 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 101 addr = (unsigned long)page_address(page);
234859e49a1532 Paul Burton 2016-03-01 102
^1da177e4c3f41 Linus Torvalds 2005-04-16 103 flush_data_cache_page(addr);
234859e49a1532 Paul Burton 2016-03-01 104
234859e49a1532 Paul Burton 2016-03-01 105 if (PageHighMem(page))
abca2500c0c1b2 Ira Weiny 2020-06-04 106 kunmap_atomic((void *)addr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 107 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 108
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (29534 bytes)
Powered by blists - more mailing lists