linux-kernel - Re: [PATCH v3 0/3] watchdog: f71808e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d25d96fa-0b88-930b-3160-fda3e69d3cba@pengutronix.de>
Date:   Tue, 16 Mar 2021 18:47:17 +0100
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-kernel@...r.kernel.org
Cc:     linux-watchdog@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API

Hello,

On 04.02.21 18:00, Ahmad Fatoum wrote:
> This series migrates the driver to the new kernel watchdog API and
> then to the driver model.
> 
> Main feedback from Guenther on v2 was that I need to split it up to
> enable review. I have done so by removing the extra refactoring for
> now and focused on the functional changes described above. The diff
> is now much better readable.
> 
> I tested it on a f81866.

Gentle ping.

> 
> v2 -> v3:
>   https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/
>   - factored out identifier renaming again for easier review
>   - reordered commits
>   - removed refactoring that can go in later. Focusing now on kernel watchdog
>     API and platform device/driver migration
>   - removed platform_device_id and changed code to match by name
> 
> v1 -> v2:
>   https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/
>   - reworked to platform device/driver pair (Guenther)
>   - squashed identifier renaming into the patches that touch
>     the respective lines anyway
>   - fixed checkpatch.pl nitpicks (Guenther)
>   - fixed locally used variable declared without static (0-day)
>   - fixed unneded line break due to old line limit (Guenther)
>   - renamed struct fintek_wdog_data to struct fintek_wdt
> 
> Ahmad Fatoum (3):
>   watchdog: f71808e_wdt: rename variant-independent identifiers appropriately
>   watchdog: f71808e_wdt: migrate to new kernel watchdog API
>   watchdog: f71808e_wdt: refactor to platform device/driver pair
> 
>  drivers/watchdog/Kconfig       |   1 +-
>  drivers/watchdog/f71808e_wdt.c | 450 +++++++---------------------------
>  2 files changed, 100 insertions(+), 351 deletions(-)
> 
> base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |