linux-kernel - Re: [PATCH 04/38] dt-bindings: power: supply: bq25890: Convert to DT schema format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 11:50:58 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     "open list:THERMAL" <linux-pm@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>
Subject: Re: [PATCH 04/38] dt-bindings: power: supply: bq25890: Convert to DT
 schema format

On Tue, Mar 16, 2021 at 10:46 AM Sebastian Reichel
<sebastian.reichel@...labora.com> wrote:
>
> Hi,
>
> On Mon, Mar 15, 2021 at 12:21:34PM -0600, Rob Herring wrote:
> > On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
> > <sebastian.reichel@...labora.com> wrote:
> > > +  ti,ibatcomp-clamp-microvolt:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    description: max. charging voltage adjustment due to expected voltage drop on in-series resistor
> >
> > You don't need a type $ref on properties with a standard unit suffix.
> > Though it looks like there's some non-standard ones (-microvolts) in
> > the series.
>
> Ok. Unfortunately most properties in this series use non-standard
> ones :(. Newer bindings using common properties have already been
> written in YAML and/or make use of simple-battery.
>
> Can we have a warning for this in the dt_binding_check? Maybe
> something like

Yeah, I'm working on that.

> superfluous $ref for property with standard suffix

And having more helpful error messages is on my todo, but not much BW
to work on ATM.

Rob