[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALHRZupARnUK5PgRjv9-TmFd9mNUg0Ms55zZEC2VuDcaEBZYLQ@mail.gmail.com>
Date: Tue, 16 Mar 2021 23:33:40 +0530
From: sundeep subbaraya <sundeep.lkml@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Hariprasad Kelam <hkelam@...vell.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
Sunil Kovvuri Goutham <sgoutham@...vell.com>,
lcherian@...vell.com, Geetha sowjanya <gakula@...vell.com>,
jerinj@...vell.com, Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private
Hi Jakub,
On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote:
> > From: Subbaraya Sundeep <sbhatta@...vell.com>
> >
> > Memory for driver private structure rvu_devlink is
> > also allocated during devlink_alloc. Hence use
> > the allocated memory by devlink_alloc and access it
> > by devlink_priv call.
> >
> > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
>
> Does it fix any bug? Looks like a coding improvement.
Without this we cannot fetch our private struct 'rvu_devlink' from any
of the functions in devlink_ops which may get added in future.
Thanks,
Sundeep
Powered by blists - more mailing lists