[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210316204034.GE395976@xz-x1>
Date: Tue, 16 Mar 2021 16:40:34 -0400
From: Peter Xu <peterx@...hat.com>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: akpm@...ux-foundation.org, ziy@...dia.com, willy@...radead.org,
william.kucharski@...cle.com, vbabka@...e.cz,
yulei.kernel@...il.com, walken@...gle.com,
aneesh.kumar@...ux.ibm.com, rcampbell@...dia.com,
thomas_os@...pmail.org, yang.shi@...ux.alibaba.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/6] mm/huge_memory.c: rework the function
vma_adjust_trans_huge()
On Tue, Mar 16, 2021 at 08:40:02AM -0400, Miaohe Lin wrote:
> +static inline void split_huge_pmd_if_needed(struct vm_area_struct *vma, unsigned long address)
> +{
> + /*
> + * If the new address isn't hpage aligned and it could previously
> + * contain an hugepage: check if we need to split an huge pmd.
> + */
> + if (address & ~HPAGE_PMD_MASK &&
> + range_in_vma(vma, address & HPAGE_PMD_MASK,
> + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE))
Since you're at it, maybe use ALIGN/ALIGN_DOWN too against HPAGE_PMD_SIZE?
> + split_huge_pmd_address(vma, address, false, NULL);
> +}
--
Peter Xu
Powered by blists - more mailing lists