linux-kernel - Re: [PATCH 2/9] objtool: Correctly handle retpoline thunk calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210316211921.r7qsuueudilmlmce@treble>
Date:   Tue, 16 Mar 2021 16:19:21 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, jgross@...e.com, mbenes@...e.cz,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] objtool: Correctly handle retpoline thunk calls

On Fri, Mar 12, 2021 at 06:16:15PM +0100, Peter Zijlstra wrote:
> Just like JMP handling, convert a direct CALL to a retpoline thunk
> into a retpoline safe indirect CALL.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> ---
>  tools/objtool/check.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -953,6 +953,18 @@ static int add_call_destinations(struct
>  					  dest_off);
>  				return -1;
>  			}
> +
> +		} else if (!strncmp(reloc->sym->name, "__x86_indirect_thunk_", 21)) {
> +			/*
> +			 * Retpoline calls are really dynamic calls in
> +			 * disguise, so convert them accodingly.

s/accodingly/accordingly/

-- 
Josh