linux-kernel - Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 16 Mar 2021 14:37:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jarvis Jiang <jarvis.w.jiang@...il.com>
Cc:     davem@...emloft.net, rppt@...ux.ibm.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-mm@...ck.org, cchen50@...ovo.com, mpearson@...ovo.com
Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem

On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote:
>  drivers/bus/mhi/devices/mhi_netdev.c          | 1830 +++++++++++++

There's already a drivers/net/mhi/

Please make sure the drivers live in their respective subsystem.

Virtio drivers don't sit under drivers/virtio, and most certainly not
under drivers/bus/virtio...

>  drivers/bus/mhi/devices/mhi_satellite.c       | 1155 +++++++++
>  drivers/bus/mhi/devices/mhi_uci.c             |  802 ++++++

Ugh, can you clarify what's the source of this code dump and if you're
coordinating with others working on Qualcomm drivers?