linux-kernel - RE: [kbuild-all] Re: [PATCH] wfx: fix irqf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8dba72b92a7407c9f2d531527137643@intel.com>
Date:   Tue, 16 Mar 2021 08:03:00 +0000
From:   "Li, Philip" <philip.li@...el.com>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        lkp <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: RE: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings

> Subject: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings
> 
> Hello,
> 
> On Monday 15 March 2021 22:09:20 CET kernel test robot wrote:
> >
> > From: kernel test robot <lkp@...el.com>
> >
> > drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ with no primary handler requested without
> IRQF_ONESHOT
> >
> >  Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> >  threaded IRQs without a primary handler need to be requested with
> >  IRQF_ONESHOT, otherwise the request will fail.
> >
> >  So pass the IRQF_ONESHOT flag in this case.
> >
> > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> >
> > CC: Jérôme Pouiller <jerome.pouiller@...abs.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: kernel test robot <lkp@...el.com>
> > ---
> >
> > url:    https://github.com/0day-ci/linux/commits/Jerome-Pouiller/wfx-get-out-from-the-staging-area/20210315-212855
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git b828324bba8f575fde487a91fec07303789dda8a
> >
> >  bus_sdio.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --- a/drivers/net/wireless/silabs/wfx/bus_sdio.c
> > +++ b/drivers/net/wireless/silabs/wfx/bus_sdio.c
> > @@ -132,7 +132,8 @@ static int wfx_sdio_irq_subscribe(void *
> >                 flags = IRQF_TRIGGER_HIGH;
> >         flags |= IRQF_ONESHOT;
> >         return devm_request_threaded_irq(&bus->func->dev, bus->of_irq, NULL,
> > -                                        wfx_sdio_irq_handler_ext, flags,
> > +                                        wfx_sdio_irq_handler_ext,
> > +                                        flags | IRQF_ONESHOT,
> >                                          "wfx", bus);
> >  }
> >
> >
> 
> Obviously, "flags" always contains IRQF_ONESHOT. So, it is a false positive.
Thanks for the feedback. Sorry about this false positive, this had been disabled
for auto report now.

> 
> 
> --
> Jérôme Pouiller
> 
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@...ts.01.org
> To unsubscribe send an email to kbuild-all-leave@...ts.01.org