linux-kernel - Re: [PATCH net-next] net: dsa: mt7530: support MDB and bridge flag operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 11:55:28 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Russell King <linux@...linux.org.uk>,
        netdev <netdev@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, linux-kernel@...r.kernel.org,
        Frank Wunderlich <frank-w@...lic-files.de>,
        René van Dorst <opensource@...rst.com>
Subject: Re: [PATCH net-next] net: dsa: mt7530: support MDB and bridge flag
 operations

On Tue, Mar 16, 2021 at 12:36:24PM +0800, DENG Qingfang wrote:
> On Tue, Mar 16, 2021 at 5:15 AM Vladimir Oltean <olteanv@...il.com> wrote:
> >
> > Actually this is just how Qingfang explained it:
> > https://patchwork.kernel.org/project/netdevbpf/patch/20210224081018.24719-1-dqfext@gmail.com/
> >
> > I just assume that MT7530/7531 switches don't need to enable flooding on
> > user ports when the only possible traffic source is the CPU port - the
> > CPU port can inject traffic into any port regardless of egress flooding
> > setting. If that's not true, I don't see how traffic in standalone ports
> > mode would work after this patch.
> 
> Correct. Don't forget the earlier version of this driver (before my
> attempt to fix roaming) disabled unknown unicast flooding (trapped to
> CPU) in the same way.

Ok, so in practice you don't really need to touch this register if it's
already all ones.