linux-kernel - Re: drivers/usb/host/ohci-hcd.c:1318 ohci_hcd_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3trJHFLV+Qy+d5hD6=nGJgw8e=UU6BsPaCZDx5yNDKtA@mail.gmail.com>
Date:   Tue, 16 Mar 2021 13:32:23 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     kbuild@...ts.01.org, Stephen Boyd <sboyd@...nel.org>,
        kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Dmitry Baryshkov <dbaryshkov@...il.com>,
        Ian Molton <spyro@....com>
Subject: Re: drivers/usb/host/ohci-hcd.c:1318 ohci_hcd_mod_init() warn:
 ignoring unreachable code.

On Tue, Mar 16, 2021 at 9:32 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
> commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
> config: arm-randconfig-m031-20210316 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> smatch warnings:
> drivers/usb/host/ohci-hcd.c:1318 ohci_hcd_mod_init() warn: ignoring unreachable code.
>
> vim +1318 drivers/usb/host/ohci-hcd.c
>
> 78c73414f4f674 Dmitry Eremin-Solenikov 2008-10-08  1313
> 5e16fabe5dbcff Sylvain Munaut          2006-12-13  1314         return retval;
>                                                                 ^^^^^^^^^^^^^
>
> 5e16fabe5dbcff Sylvain Munaut          2006-12-13  1315
> 5e16fabe5dbcff Sylvain Munaut          2006-12-13  1316         /* Error path */
> 78c73414f4f674 Dmitry Eremin-Solenikov 2008-10-08  1317  #ifdef TMIO_OHCI_DRIVER
> 78c73414f4f674 Dmitry Eremin-Solenikov 2008-10-08 @1318         platform_driver_unregister(&TMIO_OHCI_DRIVER);
>                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Unreachable

It looks like this has been the case since tmio support was added in:
78c73414f4f6 ("USB: ohci: add support for tmio-ohci cell")

I wonder if any of the original developers are still around to fix it, it should
be trivial.

       Arnd