linux-kernel - Re: [RESEND PATCH 01/42] mfd: arizona: use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 14:28:18 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andy Shevchenko <andy@...nel.org>, Milo Kim <milo.kim@...com>,
        Tony Lindgren <tony@...mide.com>, Ray Jui <rjui@...adcom.com>,
        Support Opensource <support.opensource@...semi.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Chen-Yu Tsai <wens@...e.org>, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [RESEND PATCH 01/42] mfd: arizona: use PLATFORM_DEVID_NONE

On 28/10/2020 23:29, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Hi Lee,

I sent this patchset some time ago, then made a resend. I did not get
any feedback from you so I just wonder - are you still considering this
patchset and shall I resend?

Best regards,
Krzysztof

> ---
>  drivers/mfd/arizona-core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 000cb82023e3..bf48372db605 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1043,8 +1043,9 @@ int arizona_dev_init(struct arizona *arizona)
>  	case CS47L24:
>  		break; /* No LDO1 regulator */
>  	default:
> -		ret = mfd_add_devices(arizona->dev, -1, early_devs,
> -				      ARRAY_SIZE(early_devs), NULL, 0, NULL);
> +		ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE,
> +				      early_devs, ARRAY_SIZE(early_devs),
> +				      NULL, 0, NULL);
>  		if (ret != 0) {
>  			dev_err(dev, "Failed to add early children: %d\n", ret);
>  			return ret;
>