linux-kernel - Re: [PATCH 2/2] kbuild: Enable DT undocumented compatible checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV3hG4ddXo6jBu52+2=n3mBLfbmoCzb4VRUQ8YvanH9+Q@mail.gmail.com>
Date:   Tue, 16 Mar 2021 14:55:18 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH 2/2] kbuild: Enable DT undocumented compatible checks

Hi Rob,

On Fri, Mar 12, 2021 at 12:38 AM Rob Herring <robh@...nel.org> wrote:
> dt-validate has an option to warn on any compatible strings which don't
> match any schema. The option has recently been improved to fix false
> positives, so let's enable the option. This is useful for tracking
> compatibles which are undocumented or not yet converted to DT schema.
> Previously, the only check of undocumented compatible strings has been
> an imperfect checkpatch.pl check.
>
> The option is enabled by default for 'dtbs_check'. This will add more
> warnings, but some platforms are down to only a handful of these
> warnings (good job!).
>
> There's about 100 cases in the binding examples, so the option is
> disabled until these are fixed. In the meantime, they can be checked
> with:
>
> make DT_CHECKER_FLAGS=-m dt_binding_check
>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: linux-kbuild@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Thanks for your patch!

This causes lots of warning when using DT_SCHEMA_FILES, as all
compatible values in bindings not specified with DT_SCHEMA_FILES
become unknown.

Perhaps this should be disabled automatically when DT_SCHEMA_FILES
is specified?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds