linux-kernel - Re: [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 14:46:36 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: broadcom: BCM4908_ENET should not default to y,
 unconditionally

On 2021-03-16 14:38, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, drop the automatic enabling of BCM4908_ENET.
> 
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Feel free to change to "default y if ARCH_BCM4908" and
> 
>     To fix this, restrict the automatic enabling of BCM4908_ENET to
>     ARCH_BCM4908.
> 
> if you think BCM4908 SoCs cannot be used without enabling this.

Yes, please make it
default y if ARCH_BCM4908
instead.