linux-kernel - RE: [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3642B7F0E8D288CFD7772CBB976B9@DM6PR11MB3642.namprd11.prod.outlook.com>
Date:   Tue, 16 Mar 2021 15:20:11 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     Oder Chiou <oder_chiou@...ltek.com>,
        "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        "R, Dharageswari" <dharageswari.r@...el.com>,
        "Nujella, Sathyanarayana" <sathyanarayana.nujella@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jie Yang <yang.jie@...ux.intel.com>,
        "Takashi Iwai" <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Fred Oh <fred.oh@...ux.intel.com>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Mark Brown <broonie@...nel.org>,
        "Ranjani Sridharan" <ranjani.sridharan@...ux.intel.com>,
        Libin Yang <libin.yang@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        "Zhi, Yong" <yong.zhi@...el.com>
Subject: RE: [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp
 support

> > +/*
> > + * rt1015:  i2c mode driver for ALC1015 and ALC1015Q
> > + * rt1015p: auto-mode driver for ALC1015, ALC1015Q, and ALC1015Q-VB
> > +*/ static const struct snd_soc_dapm_route rt1015p_1dev_dapm_routes[]
> > += {
> > +	/* speaker */
> > +	{ "Left Spk", NULL, "Speaker" },
> > +	{ "Right Spk", NULL, "Speaker" },
> > +};
> > +
> > +static const struct snd_soc_dapm_route rt1015p_2dev_dapm_routes[] = {
> > +	/* speaker */
> > +	{ "Left Spk", NULL, "Left Speaker" },
> > +	{ "Right Spk", NULL, "Right Speaker" }, };
> 
> I am confused by these routes...
> 
> is this a result of using the codec confs below only when there are 2 amps with
> their own enable pin?
Yes, we need to use the prefix in codec confs when there are two device instances.

> 
> You still have 2 amps even in the 1dev case, so I want to make sure the code has
> enough comments so that we don't lose track of the design.
> 
> The rest of the code looks fine.
> 
There are always two amps on the board for stereo output. If the two amps sharing
one enable pin, ODM will implement only one device instance in the ACPI table
because there is only one GPIO to control in codec driver.

I'll upload a v3 with more comment.


Regards,
Brent