linux-kernel - Re: [PATCH 16/38] dt-bindings: power: supply: tps65217: Convert to DT schema format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210316162045.cvvb226rpzxbovdl@earth.universe>
Date:   Tue, 16 Mar 2021 17:20:45 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     "open list:THERMAL" <linux-pm@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>
Subject: Re: [PATCH 16/38] dt-bindings: power: supply: tps65217: Convert to
 DT schema format

Hi Rob,

On Mon, Mar 15, 2021 at 12:33:23PM -0600, Rob Herring wrote:
> On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
> <sebastian.reichel@...labora.com> wrote:
> > +  interrupts:
> > +    minItems: 2
> > +    maxItems: 2
> 
> We've lost info that was in the original binding. You could do
> something like this:
> 
> items:
>   - description: USB charger
>     const: 0
>   - description: AC charger
>     const: 1
> 
> (Usually the interrupt values would be out of scope of the binding,
> but I guess here it makes some sense.)

I initially did this, but it did not work. I see the following for
dt_binding_check (dtbs_check triggers the same):

Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts:0: [0] is too short
	From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml
Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts: [[0], [1]] is too long
	From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml
Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts: Additional items are not allowed ([1] was unexpected)
	From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml

Seemed to be a limitation in the validation tool, so I just dropped
the extra information. If we do not want to loose information I can
add it to the description, or should the validation tool be fixed?
I suppose it's kind of unusual, that the binding can provide the
interrupt line numbers.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)