linux-kernel - Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210316163240.GA1111731@BV030612LT>
Date:   Tue, 16 Mar 2021 18:32:40 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@...il.com>
To:     David Miller <davem@...hat.com>
Cc:     andrew@...n.ch, kuba@...nel.org, robh+dt@...nel.org,
        afaerber@...e.de, mani@...nel.org, p.zabel@...gutronix.de,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl
 Ethernet MAC driver

On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote:
> From: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> Date: Mon, 15 Mar 2021 13:29:17 +0200
> 
> > +
> > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK)
> > +static int debug = -1;
> > +module_param(debug, int, 0);
> > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
> 
> Module parameters are strongly discouraged in networking drivers, pplease delete this
> ad just pass the default to netif_mdg_init(), thanks!

Ups, I was not aware of this since I've seen it in quite a lot of drivers.

Thanks for pointing this out, I will take care of it in the next
revision.

Kind regards,
Cristi