linux-kernel - Re: [PATCH] omapdrm/dss/dsi.c:modify 'u32'->'int'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93f05e6c-21ad-5b4b-3406-14229ea4feef@kernel.org>
Date:   Wed, 17 Mar 2021 13:54:39 +0200
From:   Tomi Valkeinen <tomba@...nel.org>
To:     ChunyouTang <tangchunyou@....com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        tangchunyou@...ong.com, airlied@...ux.ie, daniel@...ll.ch,
        sebastian.reichel@...labora.com, laurent.pinchart@...asonboard.com
Subject: Re: [PATCH] omapdrm/dss/dsi.c:modify 'u32'->'int'

Hi,

On 17/03/2021 11:48, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@...ong.com>
> 
> 1.the type of mipi_dsi_create_packet id int
> 2.u32 can not < 0
> 
> Signed-off-by: tangchunyou <tangchunyou@...ong.com>
> ---
>   drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 8e11612..11c502d 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -2149,7 +2149,7 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc,
>   			     const struct mipi_dsi_msg *msg)
>   {
>   	struct mipi_dsi_packet pkt;
> -	u32 r;
> +	int r;
>   
>   	r = mipi_dsi_create_packet(&pkt, msg);
>   	if (r < 0)
> 

I have already applies a similar patch "drm/omap: dsi: fix unsigned 
expression compared with zero".

  Tomi