linux-kernel - Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5B9hGHei56riPCvOjx-TmwLiEtB=3m4WZh5b8bsWowBpw@mail.gmail.com>
Date:   Wed, 17 Mar 2021 08:57:31 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Heiko Thiery <heiko.thiery@...il.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Lucas Stach <l.stach@...gutronix.de>,
        Baruch Siach <baruch@...s.co.il>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards

Hi Heiko,

On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery <heiko.thiery@...il.com> wrote:

> > Do we really want it to be built-in?  If so, it would be nice to have some
> > comments about that in commit log.
>
> Why would you not want it? I see other SOC PCI controllers are also
> enabled. I would like to have it because we have an Intel e1000 on our
> pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we
> would have the PCI support with the default defconfig. On the NXP
> imx8mq EVK a m.2 is connected to the PCI interface.
>
> Is this the kind of comments you want?

You have selected the driver to be built-in:
CONFIG_PCI_IMX6=y

Shawn's question is why it needs to be built-in instead of a kernel module:

CONFIG_PCI_IMX6=m

On arch/arm64/configs/defconfig the preference is to select the
options as modules, whenever possible.

If it can't be a module and needs to be built-in, then please provide
a justification in the commit log.

Hope this can clarify.