linux-kernel - Re: [PATCH] misc/sgi-xp: use NULL instead of using plain integer as pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210317145309.GM1938704@swahl-home.5wahls.com>
Date:   Wed, 17 Mar 2021 09:53:09 -0500
From:   Steve Wahl <steve.wahl@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     robinmholt@...il.com, steve.wahl@....com, mike.travis@....com,
        arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc/sgi-xp: use NULL instead of using plain integer as
 pointer

Reviewed-by: Steve Wahl	<steve.wahl@....com>

On Tue, Mar 16, 2021 at 04:57:21PM +0800, Yang Li wrote:
> This fixes the following sparse warnings:
> drivers/misc/sgi-xp/xpc_main.c:210:23: warning: Using plain integer as
> NULL pointer
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/misc/sgi-xp/xpc_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
> index 84610bb..b2c3c22 100644
> --- a/drivers/misc/sgi-xp/xpc_main.c
> +++ b/drivers/misc/sgi-xp/xpc_main.c
> @@ -207,7 +207,7 @@
>  {
>  	xpc_arch_ops.heartbeat_init();
>  	timer_setup(&xpc_hb_timer, xpc_hb_beater, 0);
> -	xpc_hb_beater(0);
> +	xpc_hb_beater(NULL);
>  }
>  
>  static void
> -- 
> 1.8.3.1
> 

-- 
Steve Wahl, Hewlett Packard Enterprise