linux-kernel - Re: [PATCH 0/2] power: supply: Add battery and AC drivers for Surface devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f124e477-2786-d842-5694-13aa4146ba34@gmail.com>
Date:   Wed, 17 Mar 2021 18:47:31 +0100
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Sebastian Reichel <sre@...nel.org>
Cc:     linux-pm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] power: supply: Add battery and AC drivers for Surface
 devices

On 3/17/21 6:39 PM, Hans de Goede wrote:
> Hi,
> 
> On 3/9/21 1:05 AM, Maximilian Luz wrote:
>> This series provides battery and AC drivers for Microsoft Surface
>> devices, where this information is provided via an embedded controller
>> (the Surface System Aggregator Module, SSAM) instead of the usual ACPI
>> interface.
>>
>> Specifically, 7th generation Surface devices, i.e. Surface Pro 7,
>> Surface Book 3, Surface Laptop 3, as well as the Surface Laptop Go use
>> this new interface.
>>
>> Note: This series depends on the
>>
>>      platform/surface: Add Surface Aggregator device registry
>>
>> series. More specifically patch
>>
>>      platform/surface: Set up Surface Aggregator device registry
>>
>> The full series has been merged into the for-next branch of the
>> platform-drivers-x86 tree [1]. The commit in question can be found at
>> [2].
>>
>> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
>> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=fc622b3d36e6d91330fb21506b9ad1e3206a4dde
> 
> Sebastian, I guess you want a pull-req from an immutable branch from me for
> that dependend commit and then you will merge these 2 patches ?
> 
> Maximillian, this only needs that commit right, or would it be better if
> I send Sebastian a pull-req for a branch with the entire series?

The entire series would be better, I think.

Strictly speaking, it only requires the mentioned commit to compile
successfully, but if anyone would want to test this they'd need the full
series (or at least the battery/power subsystem commit) due to the
device instantiation.

Same reasoning applies to the HID series.

Thanks,
Max