linux-kernel - Re: [PATCH] MIPS: generic: use true and false for bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFJ9oCfL8gWWPh7b@piout.net>
Date:   Wed, 17 Mar 2021 23:07:28 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     UNGLinuxDriver@...rochip.com, paulburton@...nel.org,
        tsbogend@...ha.franken.de, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: generic: use true and false for bool variable

On 15/03/2021 15:15:43+0800, Yang Li wrote:
> fixed the following coccicheck:
> ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in
> function 'ocelot_detect' with return type bool
> 

Can you elaborate why this is an issue and what exactly is fixed?
Even the original coccinelle script submission doesn't give any good
reason.

bool in Linux is _Bool and, as per C99, it holds either 0 or 1, not true
or false.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com