linux-kernel - Re: [PATCH 2/4] clocksource: riscv: Using CPUHP_AP_ONLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-2d96ba73-2578-4f60-b81b-75da618ff41e@palmerdabbelt-glaptop>
Date:   Tue, 16 Mar 2021 20:36:08 -0700 (PDT)
From:   Palmer Dabbelt <palmerdabbelt@...gle.com>
To:     guoren@...nel.org
CC:     guoren@...nel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-csky@...r.kernel.org,
        linux-arch@...r.kernel.org, guoren@...ux.alibaba.com,
        peterz@...radead.org, tglx@...utronix.de,
        Arnd Bergmann <arnd@...db.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Anup Patel <Anup.Patel@....com>, Christoph Hellwig <hch@....de>
Subject:     Re: [PATCH 2/4] clocksource: riscv: Using CPUHP_AP_ONLINE_DYN

On Mon, 01 Mar 2021 06:28:20 PST (-0800), guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
>
> Remove RISC-V clocksource custom definitions in hotplug.h:
>  - CPUHP_AP_RISCV_TIMER_STARTING
>
> For coding convention.
>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Anup Patel <anup.patel@....com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Palmer Dabbelt <palmerdabbelt@...gle.com>
> Tested-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Link: https://lore.kernel.org/lkml/CAHk-=wjM+kCsKqNdb=c0hKsv=J7-3Q1zmM15vp6_=8S5XfGMtA@mail.gmail.com/
> ---
>  drivers/clocksource/timer-riscv.c | 4 ++--
>  include/linux/cpuhotplug.h        | 1 -
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
> index c51c5ed..43aee27 100644
> --- a/drivers/clocksource/timer-riscv.c
> +++ b/drivers/clocksource/timer-riscv.c
> @@ -150,10 +150,10 @@ static int __init riscv_timer_init_dt(struct device_node *n)
>  		return error;
>  	}
>
> -	error = cpuhp_setup_state(CPUHP_AP_RISCV_TIMER_STARTING,
> +	error = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
>  			 "clockevents/riscv/timer:starting",
>  			 riscv_timer_starting_cpu, riscv_timer_dying_cpu);
> -	if (error)
> +	if (error < 0)
>  		pr_err("cpu hp setup state failed for RISCV timer [%d]\n",
>  		       error);
>  	return error;
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index 14f49fd..f60538b 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -130,7 +130,6 @@ enum cpuhp_state {
>  	CPUHP_AP_MARCO_TIMER_STARTING,
>  	CPUHP_AP_MIPS_GIC_TIMER_STARTING,
>  	CPUHP_AP_ARC_TIMER_STARTING,
> -	CPUHP_AP_RISCV_TIMER_STARTING,
>  	CPUHP_AP_CLINT_TIMER_STARTING,
>  	CPUHP_AP_CSKY_TIMER_STARTING,
>  	CPUHP_AP_HYPERV_TIMER_STARTING,

Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

Just like the previous one.  Presumably CLINT is ours as well?

Thanks!