[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1615952318-4861-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Date: Wed, 17 Mar 2021 11:38:38 +0800
From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To: dhowells@...hat.com
Cc: davem@...emloft.net, kuba@...nel.org,
linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Subject: [PATCH] rxrpc: rxkad: replace if (cond) BUG() with BUG_ON()
Fix the following coccicheck warnings:
./net/rxrpc/rxkad.c:1140:2-5: WARNING: Use BUG_ON instead of if
condition followed by BUG.
Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
net/rxrpc/rxkad.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index e2e9e9b..bfa3d9a 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -1135,9 +1135,8 @@ static void rxkad_decrypt_response(struct rxrpc_connection *conn,
ntohl(session_key->n[0]), ntohl(session_key->n[1]));
mutex_lock(&rxkad_ci_mutex);
- if (crypto_sync_skcipher_setkey(rxkad_ci, session_key->x,
- sizeof(*session_key)) < 0)
- BUG();
+ BUG_ON(crypto_sync_skcipher_setkey(rxkad_ci, session_key->x,
+ sizeof(*session_key)) < 0);
memcpy(&iv, session_key, sizeof(iv));
--
1.8.3.1
Powered by blists - more mailing lists