[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fef8ca3b-97ae-5c19-69ea-bb1dfe88cf9c@huawei.com>
Date: Wed, 17 Mar 2021 13:57:57 +0800
From: Kefeng Wang <wangkefeng.wang@...wei.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
<linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
CC: <linux-ia64@...r.kernel.org>, <linux-sh@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
Catalin Marinas <catalin.marinas@....com>,
"Dave Hansen" <dave.hansen@...ux.intel.com>, <linux-mm@...ck.org>,
Guo Ren <guoren@...nel.org>, <sparclinux@...r.kernel.org>,
<linux-riscv@...ts.infradead.org>, Jonas Bonn <jonas@...thpole.se>,
<linux-s390@...r.kernel.org>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
<linux-hexagon@...r.kernel.org>,
Huacai Chen <chenhuacai@...nel.org>,
"Russell King" <linux@...linux.org.uk>,
<linux-csky@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>,
<linux-snps-arc@...ts.infradead.org>,
<linux-xtensa@...ux-xtensa.org>,
Heiko Carstens <hca@...ux.ibm.com>,
<linux-um@...ts.infradead.org>, <linux-m68k@...ts.linux-m68k.org>,
<openrisc@...ts.librecores.org>,
<linux-arm-kernel@...ts.infradead.org>,
Richard Henderson <rth@...ddle.net>,
<linux-parisc@...r.kernel.org>, <linux-mips@...r.kernel.org>,
Palmer Dabbelt <palmer@...belt.com>,
<linux-alpha@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2] mm: Move mem_init_print_info() into mm_init()
On 2021/3/17 13:48, Christophe Leroy wrote:
>
>
> Le 17/03/2021 à 02:52, Kefeng Wang a écrit :
>> mem_init_print_info() is called in mem_init() on each architecture,
>> and pass NULL argument, so using void argument and move it into
>> mm_init().
>>
>> Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> ---
>> v2:
>> - Cleanup 'str' line suggested by Christophe and ACK
>>
>> arch/alpha/mm/init.c | 1 -
>> arch/arc/mm/init.c | 1 -
>> arch/arm/mm/init.c | 2 --
>> arch/arm64/mm/init.c | 2 --
>> arch/csky/mm/init.c | 1 -
>> arch/h8300/mm/init.c | 2 --
>> arch/hexagon/mm/init.c | 1 -
>> arch/ia64/mm/init.c | 1 -
>> arch/m68k/mm/init.c | 1 -
>> arch/microblaze/mm/init.c | 1 -
>> arch/mips/loongson64/numa.c | 1 -
>> arch/mips/mm/init.c | 1 -
>> arch/mips/sgi-ip27/ip27-memory.c | 1 -
>> arch/nds32/mm/init.c | 1 -
>> arch/nios2/mm/init.c | 1 -
>> arch/openrisc/mm/init.c | 2 --
>> arch/parisc/mm/init.c | 2 --
>> arch/powerpc/mm/mem.c | 1 -
>> arch/riscv/mm/init.c | 1 -
>> arch/s390/mm/init.c | 2 --
>> arch/sh/mm/init.c | 1 -
>> arch/sparc/mm/init_32.c | 2 --
>> arch/sparc/mm/init_64.c | 1 -
>> arch/um/kernel/mem.c | 1 -
>> arch/x86/mm/init_32.c | 2 --
>> arch/x86/mm/init_64.c | 2 --
>> arch/xtensa/mm/init.c | 1 -
>> include/linux/mm.h | 2 +-
>> init/main.c | 1 +
>> mm/page_alloc.c | 10 +++++-----
>> 30 files changed, 7 insertions(+), 42 deletions(-)
>>
>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 89314651dd62..c2e0b3495c5a 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -2373,7 +2373,7 @@ extern unsigned long free_reserved_area(void
>> *start, void *end,
>> int poison, const char *s);
>> extern void adjust_managed_page_count(struct page *page, long
>> count);
>> -extern void mem_init_print_info(const char *str);
>> +extern void mem_init_print_info(void);
>
> Sorry I didn't see that in previous patch.
>
> 'extern' keyword is pointless for function prototypes and is
> deprecated, you should remove it.
>
> That said,
>
> Reviewed-by: Christophe Leroy <christophe.leroy@....fr> # focussed on
> powerpc
Thanks, let's wait for more feedback from other architectures, if
necessary, will send a new one.
>
>> extern void reserve_bootmem_region(phys_addr_t start, phys_addr_t
>> end);
> .
>
Powered by blists - more mailing lists