linux-kernel - Re: [PATCH] selftests/kvm: add get_msr_index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c08773f1-4b84-bb19-cda8-c8ac6ffffdaf@redhat.com>
Date:   Thu, 18 Mar 2021 18:33:35 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Andrew Jones <drjones@...hat.com>,
        Emanuele Giuseppe Esposito <eesposit@...hat.com>
Cc:     linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/kvm: add get_msr_index_features

On 18/03/21 18:03, Andrew Jones wrote:
>>
>>  TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
>> +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features
> 
> Maybe we should give up trying to keep an alphabetic order.

FWIW I had fixed that but yeah maybe we should just give up.

>> +int main(int argc, char *argv[])
>> +{
>> +	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
>> +		test_get_msr_feature();
>> +
>> +	test_get_msr_index();
> Missing return
> 
>> +}

"main" is special, it's okay not to have a return there.

Paolo