linux-kernel - Re: [PATCH] init/Kconfig: make COMPILE_TEST depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Mar 2021 20:38:08 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Guenter Roeck <linux@...ck-us.net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Johannes Weiner <hannes@...xchg.org>,
        KP Singh <kpsingh@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Terrell <terrelln@...com>,
        Quentin Perret <qperret@...gle.com>,
        Valentin Schneider <valentin.schneider@....com>
Subject: Re: [PATCH] init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM

On 24.02.21 17:23, Guenter Roeck wrote:

> Unfortunately that does not reflect reality, which was the reason
> for the above two commits. Problem here is that the cost is not paid
> by the driver authors, but by architectures which don't support HAS_IOMEM,
> specifically s390. Driver authors tend to enable COMPILE_TEST but never
> test on a system with HAS_IOMEM=n (and/or ignore test results provided by
> build robots).

Still, I believe the bug should be fixed at the source.

Maybe these bots do so much traffic that nobody really cares about them.
Do they directly address the author and the corresponding maintainer ?
(if that ever happens to one of my drivers, please let me know)

> To a lesser degree, we see the same happen with 32-bit targets. Driver
> authors often don't compile their drivers in 32-bit mode (just look
> at 32-bit i386 builds in next-20210224 to see an example). Then it is
> often up to others to track down and fix the problems. Fortunately,
> there are still more than a few people who are still interested in
> 32-bit builds, and problems with those builds tend to get fixed quickly.
> This is not the case with HAS_IOMEM related issues, where the burden
> is on very few people.

Could we set up a separate build bot for those configurations, with a
different from: address and an a special warning text, so maintainers
quickly see they *should* pay attention.

IMHO, this is primarily a problem of handling the massive traffic
on lkml and sorting out whats relevant for oneself.



--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287