linux-kernel - Re: [PATCH] audit: log nftables configuration change events once per table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202103190338.ZPPYJNaT-lkp@intel.com>
Date:   Fri, 19 Mar 2021 03:39:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Richard Guy Briggs <rgb@...hat.com>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netfilter-devel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Paul Moore <paul@...l-moore.com>,
        Eric Paris <eparis@...isplace.org>,
        Steve Grubb <sgrubb@...hat.com>,
        Richard Guy Briggs <rgb@...hat.com>,
        Florian Westphal <fw@...len.de>, Phil Sutter <phil@....cc>,
        twoerner@...hat.com
Subject: Re: [PATCH] audit: log nftables configuration change events once per
 table

Hi Richard,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on nf/master nf-next/master linux/master linus/master v5.12-rc3 next-20210318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-log-nftables-configuration-change-events-once-per-table/20210318-234408
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: sparc64-randconfig-p002-20210318 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6c3d6ac0f39a29e8474b0ff59609e3c3168339c0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Richard-Guy-Briggs/audit-log-nftables-configuration-change-events-once-per-table/20210318-234408
        git checkout 6c3d6ac0f39a29e8474b0ff59609e3c3168339c0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/sparc/kernel/ptrace_64.c:25:
>> include/linux/audit.h:121:17: error: 'nft2audit_op' defined but not used [-Werror=unused-const-variable=]
     121 | static const u8 nft2audit_op[] = { // enum nf_tables_msg_types
         |                 ^~~~~~~~~~~~
   cc1: all warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS || MCOUNT
   Selected by
   - LOCKDEP && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86


vim +/nft2audit_op +121 include/linux/audit.h

   120	
 > 121	static const u8 nft2audit_op[] = { // enum nf_tables_msg_types
   122		/* NFT_MSG_NEWTABLE	*/	AUDIT_NFT_OP_TABLE_REGISTER,
   123		/* NFT_MSG_GETTABLE	*/	AUDIT_NFT_OP_INVALID,
   124		/* NFT_MSG_DELTABLE	*/	AUDIT_NFT_OP_TABLE_UNREGISTER,
   125		/* NFT_MSG_NEWCHAIN	*/	AUDIT_NFT_OP_CHAIN_REGISTER,
   126		/* NFT_MSG_GETCHAIN	*/	AUDIT_NFT_OP_INVALID,
   127		/* NFT_MSG_DELCHAIN	*/	AUDIT_NFT_OP_CHAIN_UNREGISTER,
   128		/* NFT_MSG_NEWRULE	*/	AUDIT_NFT_OP_RULE_REGISTER,
   129		/* NFT_MSG_GETRULE	*/	AUDIT_NFT_OP_INVALID,
   130		/* NFT_MSG_DELRULE	*/	AUDIT_NFT_OP_RULE_UNREGISTER,
   131		/* NFT_MSG_NEWSET	*/	AUDIT_NFT_OP_SET_REGISTER,
   132		/* NFT_MSG_GETSET	*/	AUDIT_NFT_OP_INVALID,
   133		/* NFT_MSG_DELSET	*/	AUDIT_NFT_OP_SET_UNREGISTER,
   134		/* NFT_MSG_NEWSETELEM	*/	AUDIT_NFT_OP_SETELEM_REGISTER,
   135		/* NFT_MSG_GETSETELEM	*/	AUDIT_NFT_OP_INVALID,
   136		/* NFT_MSG_DELSETELEM	*/	AUDIT_NFT_OP_SETELEM_UNREGISTER,
   137		/* NFT_MSG_NEWGEN	*/	AUDIT_NFT_OP_GEN_REGISTER,
   138		/* NFT_MSG_GETGEN	*/	AUDIT_NFT_OP_INVALID,
   139		/* NFT_MSG_TRACE	*/	AUDIT_NFT_OP_INVALID,
   140		/* NFT_MSG_NEWOBJ	*/	AUDIT_NFT_OP_OBJ_REGISTER,
   141		/* NFT_MSG_GETOBJ	*/	AUDIT_NFT_OP_INVALID,
   142		/* NFT_MSG_DELOBJ	*/	AUDIT_NFT_OP_OBJ_UNREGISTER,
   143		/* NFT_MSG_GETOBJ_RESET	*/	AUDIT_NFT_OP_OBJ_RESET,
   144		/* NFT_MSG_NEWFLOWTABLE	*/	AUDIT_NFT_OP_FLOWTABLE_REGISTER,
   145		/* NFT_MSG_GETFLOWTABLE	*/	AUDIT_NFT_OP_INVALID,
   146		/* NFT_MSG_DELFLOWTABLE	*/	AUDIT_NFT_OP_FLOWTABLE_UNREGISTER,
   147		/* NFT_MSG_MAX		*/	AUDIT_NFT_OP_INVALID,
   148	};
   149	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (23636 bytes)