linux-kernel - Re: [PATCH V3 1/5] dt-bindings: net: renesas,etheravb: Add additional clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2618a49-5314-af7a-0367-2519de78f957@gmail.com>
Date:   Thu, 18 Mar 2021 23:18:12 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Adam Ford <aford173@...il.com>, netdev@...r.kernel.org
Cc:     aford@...conembedded.com,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Magnus Damm <magnus.damm@...il.com>,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/5] dt-bindings: net: renesas,etheravb: Add additional
 clocks

Hi!

On 2/24/21 2:51 PM, Adam Ford wrote:

> The AVB driver assumes there is an external crystal, but it could
> be clocked by other means.  In order to enable a programmable
> clock, it needs to be added to the clocks list and enabled in the
> driver.  Since there currently only one clock, there is no
> clock-names list either.
> 
> Update bindings to add the additional optional clock, and explicitly
> name both of them.
> 
> Signed-off-by: Adam Ford <aford173@...il.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Acked-by: Rob Herring <robh@...nel.org>

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>

[...]

PS: Sorry for the dalay reviewing...

MBR, Sergei