linux-kernel - Re: [PATCH net-next v3 2/4] net: ipa: use upper_32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e211d822-ff08-7a83-a0b2-d0be36c30222@gmail.com>
Date:   Thu, 18 Mar 2021 14:35:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Alex Elder <elder@...aro.org>, davem@...emloft.net, kuba@...nel.org
Cc:     bjorn.andersson@...aro.org, evgreen@...omium.org,
        cpratapa@...eaurora.org, subashab@...eaurora.org, elder@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/4] net: ipa: use upper_32_bits()



On 3/18/2021 11:59 AM, Alex Elder wrote:
> Use upper_32_bits() to extract the high-order 32 bits of a DMA
> address.  This avoids doing a 32-position shift on a DMA address
> if it happens not to be 64 bits wide.  Use lower_32_bits() to
> extract the low-order 32 bits (because that's what it's for).
> 
> Suggested-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Alex Elder <elder@...aro.org>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian