linux-kernel - Re: [PATCH v2] smp: kernel/panic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa53f274-b10c-f44e-0da8-6307b366d50e@csgroup.eu>
Date:   Thu, 18 Mar 2021 07:11:46 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     "heying (H)" <heying24@...wei.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     frederic@...nel.org, paulmck@...nel.org, clg@...d.org,
        qais.yousef@....com, johnny.chenyi@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] smp: kernel/panic.c - silence warnings



Le 18/03/2021 à 03:56, heying (H) a écrit :
> 
> 在 2021/3/18 4:09, Ingo Molnar 写道:
>> * Peter Zijlstra <peterz@...radead.org> wrote:
>>
>>> Now, the C people figured that distinction was useless and allowed
>>> sloppiness. But I still think there's merrit to that. And as
>>> mentioned earlier, it is consistent with variable declarations.
>> Fully agreed, and my other point was that it's also consistent with
>> the other existing externs were used *in the same header file*
>> already.
>>
>> I.e. there's nothing more sloppy than mixing different styles within
>> the same header. Checkpatch needs to be fixed or ignored here.
> 
> Thank you all for the reply!
> 
> There are already mixing different styles within linux/smp.h. I mean 'extern' and
> 
> non 'extern' func declarations both exist in this header. Since two of you three
> 
> think that 'extern' is needed, I'll add it and resend my patch.
> 
> 

As you are pointing, there are already non 'extern' func protoypes in the file, the conversion has 
already started, so flagging new prototypes with 'extern' would be a step backwards.