linux-kernel - Re: [PATCH v2] usb: cdns3: Optimize DMA request buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210318073245.GA645121@infradead.org>
Date:   Thu, 18 Mar 2021 07:32:45 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Sanket Parmar <sparmar@...ence.com>
Cc:     peter.chen@...nel.org, pawell@...ence.com, a-govindraju@...com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kurahul@...ence.com, gregkh@...uxfoundation.org, kishon@...com,
        hch@...radead.org
Subject: Re: [PATCH v2] usb: cdns3: Optimize DMA request buffer allocation

On Wed, Mar 17, 2021 at 08:13:59PM +0100, Sanket Parmar wrote:
> dma_alloc_coherent() might fail on the platform with a small
> DMA region.
> 
> To avoid such failure in cdns3_prepare_aligned_request_buf(),
> dma_alloc_coherent() is replaced with dma_alloc_noncoherent()
> to allocate aligned request buffer of dynamic length.
> 
> Reported-by: Aswath Govindraju <a-govindraju@...com>
> Signed-off-by: Sanket Parmar <sparmar@...ence.com>

Looks good to me:

Reviewed-by: Christoph Hellwig <hch@....de>