linux-kernel - Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Mar 2021 09:55:13 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH master] module: remove never implemented
 MODULE_SUPPORTED_DEVICE

On Wed, Mar 17, 2021 at 01:17:32PM -0700, Linus Torvalds wrote:
> On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky <leon@...nel.org> wrote:
> >
> > I'm sending this patch to you directly because it is much saner to
> > apply it in one place instead of multiple patches saga that will
> > span for at least two cycles if per-maintainer path will be taken.
> >
> > It applies cleanly on v5.12-rc2 and completely unharmful.
>
> You have an odd whitespace-only part in the patch inside the comment
> underneath the "remove RME,Hammerfall" case.

This is something that I missed, my VIM changed whitespaces in many old
files and I didn't pay attention when added that chunk.

>
> Also, your email seems to have swallowed spaces at the ends of lines.
>
> I can (and did) apply the patch with "--whitespace=fix", but that then
> causes git to fix some _other_ whitespace too, so the end result isn't
> quite the same. Oh well.
>
> Please check what's up with your email sending client that it seems to
> remove space at end of lines in patches.

This is strange, I'm sending patches with "git send-email" with pretty
standard settings:

   28 [sendemail]
   29         smtpserver = /usr/local/bin/msmtp-enqueue.sh
   30         suppresscc = self
   31         chainReplyTo = false
   32         confirm = always
   33         from = Leon Romanovsky <leon@...nel.org>
   34         envelopeSender = Leon Romanovsky <leon@...nel.org>
   35         signingkey = leon@...nel.org
   36         composeencoding = utf-8

Also, I'm using mail.kernel.org as a SMTP especially to make sure that
my mails are not mangled by our exchange server.

Are you sure that such change came from me and not from "--whitespace=fix"?

Thanks

>
>             Linus