linux-kernel - Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFMauIq/L83Trvv6@vkoul-mobl.Dlink>
Date:   Thu, 18 Mar 2021 14:47:44 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Georgi Djakov <georgi.djakov@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Odelu Kukatla <okukatla@...eaurora.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect
 provider driver

On 18-03-21, 09:08, Georgi Djakov wrote:
> Hi Vinod,
> 
> On 3/2/21 15:43, Vinod Koul wrote:
> > Add driver for the Qualcomm interconnect buses found in SM8i350 based
> 
> Still SM8i350? Have you checked my comments on v1?

Oops missed to fix the commit log :(


> > +config INTERCONNECT_QCOM_SM8350
> > +	tristate "Qualcomm SM8350 interconnect driver"
> > +	depends on INTERCONNECT_QCOM
> > +	depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
> 
> Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE

fixed now

> > +#include <linux/device.h>
> > +#include <linux/interconnect.h>
> > +#include <linux/interconnect-provider.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of_platform.h>
> 
> Is this used?

I need either of_device or of_platform, not both :)

I decided to keep of_device and also get rid of device.h

Also checked we can remove interconnect.h as interconnect-provider.h
already has it. So will send these in next version shortly

-- 
~Vinod