linux-kernel - Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR19MB3693144BDCCAEF6F7FAB6BC0B1699@MN2PR19MB3693.namprd19.prod.outlook.com>
Date:   Thu, 18 Mar 2021 09:24:22 +0000
From:   Rahul Tanwar <rtanwar@...linear.com>
To:     Randy Dunlap <rdunlap@...radead.org>, Pavel Machek <pavel@....cz>
CC:     Arnd Bergmann <arnd@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Adam Borowski <kilobyte@...band.pl>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        John Crispin <john@...ozen.org>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Cheol Yong Kim <ckim@...linear.com>,
        Qiming Wu <qwu@...linear.com>
Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

Hi Randy,

On 18/3/2021 11:02 am, Randy Dunlap wrote:
> This email was sent from outside of MaxLinear.
> 
> 
> Hi,
> 
> For the leds/blink/Kconfig file at least, something has
> changed all of the tabs to spaces.
> 
> Keywords in Kconfig files should be indented with one tab,
> while help text should be indented with one tab + 2 spaces.
>


Hmm, facing some IT issues with git send-email so i had to send it by 
other means. I will fix it in V1 by ensuring that i send using git.


> 
> On 3/17/21 3:04 AM, Rahul Tanwar wrote:
>> Remove unnecessary Kconfig symbol LEDS_BLINK
>> Improve Kconfig help text to make it more useful.
>>
>> Signed-off-by: Rahul Tanwar <rtanwar@...linear.com>
>> ---
>>
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 6dedc58c47b3..2de2973fbc6b 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,21 +1,19 @@
>> -menuconfig LEDS_BLINK
>> -       bool "LED Blink support"
>> -       depends on LEDS_CLASS
>> -       help
>> -         This option enables blink support for the leds class.
>> -         If unsure, say Y.
>> -
>> -if LEDS_BLINK
>> -
>> -config LEDS_BLINK_LGM
>> -       tristate "LED support for Intel LGM SoC series"
>> +config LEDS_LGM
>> +       tristate "LED support for LGM SoC series"
>>           depends on GPIOLIB
>>           depends on LEDS_CLASS
>>           depends on MFD_SYSCON
>>           depends on OF
>>           help
>> -         Parallel to serial conversion, which is also called SSO
>> controller,
>> -         can drive external shift register for LED outputs.
>> -         This enables LED support for Serial Shift Output controller(SSO).
>> +         This option enables support for LEDs connected to GPIO lines on
>> +         Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
> 
>                        Mountain (LGM)
> 
>> +         Shift Output(SSO) controller. The driver supports hardware
> 
>                    Output (SSO)
> 
>> +         blinking with a configurable LED update/blink frequency in two
>> +         modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 KHz in
>> +         high speed mode. The LEDs can be configured to be triggered by
>> +         SW/CPU or by hardware. Say 'Y' here if you are working on LGM
> 
> Please spell out "software".
> 
>> +         SoC based platform.
>> +
>> +         To compile this driver as a module, choose M here: the
>> +         module will be called leds-lgm-sso.
>>
>> -endif # LEDS_BLINK
> 

Well noted about above improvements suggestions. Shall update in V1. Thanks.

Regards,
Rahul

> thanks.
> --
> ~Randy
> 
>