linux-kernel - Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210318112859.GA25002@e121166-lin.cambridge.arm.com>
Date:   Thu, 18 Mar 2021 11:29:10 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Will Deacon <will@...nel.org>
Cc:     Tom Saeger <tom.saeger@...cle.com>, linux-doc@...r.kernel.org,
        Jonathan Corbet <corbet@....net>,
        Thomas Tai <thomas.tai@...cle.com>,
        Konrad Rzeszutek Wilk <konrad@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Al Stone <al.stone@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ahs3@...hat.com, ardb@...nel.org
Subject: Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT

[+ Al, Ard]

On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote:
> [+Lorenzo]
> 
> On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> > not depend on x86.
> > 
> > Update arm64 acpi documentation, changing IBFT support status from
> > "Not Supported" to "Optional".
> > Opportunistically re-flow paragraph for changed lines.
> > 
> > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
> > 
> > Signed-off-by: Tom Saeger <tom.saeger@...cle.com>
> > ---
> >  Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Lorenzo, please could you ack the change below if you're happy with it?
> If so, I can take it as a fix.

I don't see any issue with this patch, more so given that the IBFT
legacy discovery method was decoupled from the ACPI table method,
so it looks sound on ARM64.

However, I would like to get Al and Ard opinions on this to make sure
there is not something I am missing (in particular wrt the rationale
behind the "Not Supported" in the docs).

Lorenzo

> Thanks,
> 
> Will
> 
> > diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> > index 377e9d224db0..0609da73970b 100644
> > --- a/Documentation/arm64/acpi_object_usage.rst
> > +++ b/Documentation/arm64/acpi_object_usage.rst
> > @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories:
> >  
> >         -  Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
> >  
> > -       -  Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT,
> > -          MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO,
> > -	  TCPA, TPM2, UEFI, XENV
> > +       -  Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> > +          IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> > +          STAO, TCPA, TPM2, UEFI, XENV
> >  
> > -       -  Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT,
> > -          MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> > +       -  Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> > +          PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> >  
> >  ====== ========================================================================
> >  Table  Usage for ARMv8 Linux
> > -- 
> > 2.31.0
> >